-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0.4xx] Multi-arch OCI images export as tarballs #46467
[release/8.0.4xx] Multi-arch OCI images export as tarballs #46467
Conversation
… docker publishing
…s it is not supported
src/Containers/Microsoft.NET.Build.Containers/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/MultiArchImage.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateImageIndex.cs
Outdated
Show resolved
Hide resolved
…ctory; add ArchiveFileRegistryTests
src/Containers/Microsoft.NET.Build.Containers/ImageIndexGenerator.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/LocalDaemons/ArchiveFileRegistry.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImage.cs
Outdated
Show resolved
Hide resolved
…postory contains /, and 'docker.io/library/' when it doesn't; add tests
… rename DockerIsAvailableAndSupportsArchFactAttribute file
I've done all my testing and am very happy with the changes here! Thanks for pushing this to done, @surayya-MS |
A test is failing on macos leg - which is unrelated to the changes in this PR. @marcpopMSFT could you please merge this on red, once tactics approve the PR? |
It's currently marked for do not merge and still servicing-consider. I can merge once it's approved. The Mac issue is #46006 and still waiting on a fix from Runtime. |
@marcpopMSFT this was just approved over email - mind merging when you have a moment? |
Context
Fixes dotnet/sdk-container-builds#609
This is a feature request from partner team - support publishing multi-arch OCI image as one combined tarball. Currently we publish separate tarballs for each architecture.
Customer impact
Without this feature customers will not be able to export multi-arch OCI image as one combined tarball, they will get separate tarballs for each architecture, and will have to combine them manually to achieve this.
Details
Current behavior for multi-arch image publishing
Behaviour after this PR
Note: in order to load a multi-arch oci image tarball, containerd image store should be enabled for Docker.
Changes made
DockerCli
.CreateNewImage
task into a separate class, to be able to reuse it inCreateImageIndex
task.SkipPublishing
parameter inCreateNewImage
task, in order to create an image but skip publish it (this is needed for multi-arch tarball publishing because we need to publish one combined tarball)Testing
Modified end to end multi-arch tests to reflect the new behavior. Tested manually as well.
Risks
Low - new tests ensure the scenarios are now covered, the existing tests ensure that other scenarios were not affected.